Re: [patch 4/6] SLUB: Avoid touching page struct when freeing toper cpu slab

[Christoph Lameter]

On Thu, 23 Aug 2007, Christoph Lameter wrote:

> So we need to also check for -1 if !NUMA
> 
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>

Sorry. No we do not need this fix. The patch is fine as is.

In slab_alloc() the slow path is entered if c->lockless is NULL. So it
does not matter for slow path determination that node_match always returns 
1 in the !NUMA case.

c->node only needs to be checked for slow path determination in 
slab_free(). And there the node_match is not called.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/