Re: what is the value of the macro "__setup_param"?

From: Paul Mundt
Date: Fri Aug 24 2007 - 05:52:31 EST


On Fri, Aug 24, 2007 at 05:19:29AM -0400, Robert P. J. Day wrote:
>
> perhaps i'm missing it, but it seems that the macro __setup_param is
> entirely superfluous:
>
> $ grep -rw __setup_param *
> include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \
> include/linux/init.h: __setup_param(str, unique_id, NULL, 0)
> include/linux/init.h: __setup_param(str, fn, fn, 0)
> include/linux/init.h: __setup_param(str, fn, fn, 1)
> include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */
> $
>
> or am i must misreading something badly?
>
Superfluous how? It does different things depending on whether MODULE is
defined or not. It's a good indicator of how often people use
__setup_param() from module context though, given the complete mismatch
of parameters. It's probably worth fixing that up at least.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/