Re: [PATCH] sched: Reduce overhead in balance_tasks()

From: Ingo Molnar
Date: Fri Aug 24 2007 - 02:04:37 EST



* Peter Williams <pwil3058@xxxxxxxxxxxxxx> wrote:

> At the moment, balance_tasks() provides low level functionality for
> both
> move_tasks() and move_one_task() (indirectly) via the load_balance()
> function (in the sched_class interface) which also provides dual
> functionality. This dual functionality complicates the interfaces and
> internal mechanisms and makes the run time overhead of operations that
> are called with two run queue locks held.
>
> This patch addresses this issue and reduces the overhead of these
> operations.

hm, i like it, and added it to my queue (probably .24 material though),
but note that it increases .text and .data overhead:

text data bss dec hex filename
41028 37794 2168 80990 13c5e sched.o.before
41349 37826 2168 81343 13dbf sched.o.after

is that expected?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/