Re: [PATCH 21/25][V3] export cpu_gdt_descr

[Glauber de Oliveira Costa]

Andi Kleen escreveu:
> On Wed, Aug 15, 2007 at 11:25:43AM -0300, Glauber de Oliveira Costa wrote:
> > On 8/15/07, Andi Kleen <ak@xxxxxxx> wrote:
> > > > +#ifdef CONFIG_PARAVIRT
> > > > +extern unsigned long *cpu_gdt_descr;
> > > No externs in .c files
> > >
> > > Normally they should be where the variable is defined
> > > anyways.
> > Given that this  variable is defined in head.S, what do you propose?
>
> Move it to C code first.

duh. I haven't noticed that this variable is already defined as extern 
in desc.h.

If you don't oppose, I'll just include it in x8664_ksyms.c

Thanks for the nitpicking, Andi.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/