Re: [linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

From: Tejun Heo
Date: Wed Aug 15 2007 - 10:55:16 EST


Alan Stern wrote:
> I think we can simply remove the error message. There's no obvious
> reason why sysfs_remove_bin_file() should complain about attempts to
> remove a nonexistent file; sysfs_remove_file() doesn't.
>
> This patch will get rid of the annoying error messages. It won't do
> anything about your keyboard's tendency to spontaneously stop working,
> alas.

Agreed but I think sysfs_remove_bin_file() should relay the return value
from sysfs_has_and_remove() to the caller.

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/