Re: 2.6.23-rc3 regression and bisection query

From: Hugh Dickins
Date: Mon Aug 13 2007 - 18:58:22 EST


On Tue, 14 Aug 2007, Alexey Starikovskiy wrote:
> Sergey Dolgov wrote:
> > On Mon, Aug 13, 2007 at 07:44:48PM +0100, Hugh Dickins wrote:
> >
> >
> >> Git bisection (with manual fixups to i386 mmiocfg horror, thanks
> >> for drawing attention to that in your changelog) accuses Alexey's
> >> ACPI: EC: If ECDT is not found, look up EC in DSDT
> >> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> >> and if I revert that along with Len's subsequent
> >> ACPI: EC: fix build warning
> >> 52fe4bdf40bc07498c5f7935551774e8f8458190
> >> then I have Fn-F4 suspending to RAM again.
> >>
> >>
> >
> > I've also noticed a regression since -rc2 in battery status reporting
> > on my HP nx7300 laptop: the output of
> >
> > cat /proc/acpi/battery/C1BE/state
> >
> > does not change after this file has been read for the the first time;
> > for exaple, the line "charging state: charged" does not change to
> > "charging state: discharging" upon unplugging the power cord.
> >
> > Reverting the above 2 commits fixes this issue for me.
> >
> > --
> > Sergey
> >
> Function to register query methods (means by which EC talks to ACPI)
> was deleted by mistake.
>
> Could you please try the attached patch?

Great, that indeed fixes my Thinkpad suspend-to-RAM cases
(both the Fn-F4, and resume from echo mem >/sys/power/state):
thanks a lot, Alexey.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/