Re: Are we properly prepared to handle 3 Socket setups?

From: Rene Herman
Date: Sun Aug 12 2007 - 16:04:39 EST


On 08/12/2007 10:35 AM, Andrew Morton wrote:

On Sun, 12 Aug 2007 05:17:10 +0200 Rene Herman <rene.herman@xxxxxxxxx> wrote:

The line just below where it does that _does_ seem to have a problem:

/*
* Maximum threshold is 125
*/
threshold = min(125, threshold);

as either the comment or the code is wrong and it seems it's the code. Added Andrew Morton to the CC for that.

Yes, that's inconsistent. And looking at Christoph's df9ecaba it's unclear
whether the comment is wrong or the code is wrong. The code is wrong, I
expect.

Extremely friendly of you to pretend I wasn't being thick at all but don't worry, I can take it. Anyways, since Christoph wasn't in CC on that one:

On 08/12/2007 05:29 AM, Roland Dreier wrote:

What's the problem? That line sets threshold to the smaller of the current value or 125, which is exactly what one would want to do if the
maximum value is 125. Just do a couple of examples: eg if threshold is
100 going into that line, then the value is left alone; if threshold is
150 then it gets set to 125; and that seems exactly correct.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/