Re: [PATCH 9/24] make atomic_read() behave consistently on ia64

[Chris Snook]

Linus Torvalds wrote:
> On Fri, 10 Aug 2007, Luck, Tony wrote:
> > Here are the functions in which they occur in the object file. You
> > may have to chase down some inlining to find the function that
> > actually uses atomic_*().
>
> Could you just make the "atomic_read()" and "atomic_set()" functions be 
> inline functions instead?
>
> That way you get nice compiler warnings when you pass the wrong kind of 
> object around.  So
>
> 	static void atomic_set(atomic_t *p, int value)
> 	{
> 		*(volatile int *)&p->value = value;
> 	}
>
> 	static int atomic_read(atomic_t *p)
> 	{
> 		return *(volatile int *)&p->value;
> 	}
>
> etc...

I'll do this for the whole patchset.  Stay tuned for the resubmit.

	-- Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/