Re: [PATCH] at91 pm: Compilation fix for at91sam926x

[Hans-Jürgen Koch]

Am Freitag 10 August 2007 00:15 schrieb Ulf Samuelsson:
> 
> > > +#if defined(CONFIG_ARCH_AT91RM9200)
> > >                         at91_sys_write(AT91_SDRAMC_SRR, 1);     /*
> > > self-refresh mode */
> 
> > Why don't use:
> > if (cpu_is_at91rm9200())
> > at91_sys_write(AT91_SDRAMC_SRR, 1);
> 
> What is the benefit?
> Will the optimizer remove the code if the CPU is not the at91rm9200?

No, it won't. cpu_is_something() is intended for runtime decisions.
Remember that the purpose of this patch was to solve a compile time
issue (see subject). AT91_SDRAMC_SRR isn't defined properly for
non-9200 processors because they don't have that register. So we need
something like #ifdef to include this line only on 9200.

Hans
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/