Re: [PATCH 2/7] Added generic lg.h in lguest directory.

[Jes Sorensen]

Glauber de Oliveira Costa wrote:
> On 8/8/07, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > Add a generic lg.h file to call the architecture specific one.
> >
> > diff --git a/drivers/lguest/lg.h b/drivers/lguest/lg.h
> > new file mode 100644
> > index 0000000..4c4356e
> > --- /dev/null
> > +++ b/drivers/lguest/lg.h
> > @@ -0,0 +1,3 @@
> > +#ifdef CONFIG_X86_32
> > +#include "i386/lg.h"
> > +#endif
>
> Wouldn't it be cleaner to do something like the asm/ includes?
> I understand that lguest now lives in drivers/ and so we don't put
> headers directly in asm-i386 , but we could come up with a similar
> thing here. 

Yeah, that would be much better, and I don't like having something in
a header file including arch specific files like that. I target to get
lguest going on non x86, so I would like to encourage anyone to think
more than x86 when trying to seperate out something :)

IMHO we should avoid any header files with asm specific code in
drivers/lguest - in a way I prefer having arch/<foo>/lguest to
drivers/lguest/<arch>, would be more esthetically compliant with
the include/asm-<arch> approach too, but thats not a big deal.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/