Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :

From: Dmitry Adamushko
Date: Thu Aug 09 2007 - 04:47:29 EST


On 09/08/07, Mitchell Erblich <erblichs@xxxxxxxxxxxxx> wrote:
> 1) * Possible wasted stats overhead during dequeue..
> sched_rt.c:
> Is RT check needed within a RT func?
> dequeue_task_rt() calls update_curr_rt()
> which checks for priority of RR or FIFO.
> [ ... ]
> Thus, I think those two lines could be removed.
>
> 2) nit....
> The comment within sched_rt.c
> -----> Adding/removing a task to/from a priority array:
> Is placed before dequeue_task_rt() where
> enqueue_task_rt() is placed above the comment
>

Both suggestions sound good. I guess, a patch would be welcomed :-)


>
> Mitchell Erblich
>

--
Best regards,
Dmitry Adamushko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/