Re: + remove-current-defines-and-uses-of-pr_err-add-pr_emerg.patchadded to -mm tree

From: Jan Engelhardt
Date: Wed Aug 08 2007 - 16:39:42 EST



On Aug 8 2007 13:31, Joe Perches wrote:
>Goals in desired implementation sequence:
>
>1 Standardization of pr_<level>
>2 Correctness of single line uses of pr_<level>
>3 Correctness of multiple line uses of printk(<level>)
>4 Removal of local near equivalents of pr_<level>
>5 Standardization of pr_<level> as single line only
>6 Conversion of single line printk(KERN_<level> to pr_level
>7 Standardize local #defines to enable/print pr_<level>
> __file__/__func__/__line__

I fail to see what problem these are trying to fix. Please post some broken
code that would 'benefit' from pr_halleluja, and why printk(level ) could not
do the same.

>8 Minimization/elimination of interleaved log messages

This is a separate, and worthwhile, thing to do, yes.
And it can be done without deviating from the regular printk().


Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/