Re: [patch 2/2] x86_64: ticket lock spinlock

[Andi Kleen]

>   *
>   * (the type definitions are in asm/spinlock_types.h)
>   */
>  
> +#if (NR_CPUS > 256)
> +#error spinlock supports a maximum of 256 CPUs
> +#endif
> +
>  static inline int __raw_spin_is_locked(raw_spinlock_t *lock)
>  {
> -	return *(volatile signed int *)(&(lock)->slock) <= 0;
> +	int tmp = *(volatile signed int *)(&(lock)->slock);

Why is slock not volatile signed int in the first place? 

> -	int oldval;
> +	short tmp;
> +        short oldval;

Broken white space?


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/