Re: [PATCH 3/8] i386: bitops: Rectify bogus "+m" constraints

[Andi Kleen]

On Monday 23 July 2007 18:05:43 Satyam Sharma wrote:
> From: Satyam Sharma <ssatyam@xxxxxxxxxxxxxx>
> 
> [3/8] i386: bitops: Rectify bogus "+m" constraints
> 
> From the gcc manual:
> 
>   Extended asm supports input-output or read-write operands. Use the
>   constraint character `+' to indicate such an operand and list it with
>   the output operands. You should only use read-write operands when the
>   constraints for the operand (or the operand in which only some of the
>   bits are to be changed) allow a register.
> 
> So, using the "+" constraint modifier for memory, like "+m" is bogus.
> We must simply specify "=m" which handles the case correctly.

I checked with Honza (cc'ed) and he stated that the + are really needed
at least in newer gcc.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/