Re: [DRIVER SUBMISSION] DRBD wants to go mainline

From: Christoph Hellwig
Date: Mon Jul 23 2007 - 04:49:23 EST


On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote:
> First of all, if you could break this up into chunks (even if they
> aren't useful individually) just to make it easier to review.

No, please don't do that I have no idea why people say that except for
drinking too much "small patches" koolaid. Small patches are the
most optimal form if you can split patches logically. There is absolutely
no point in splitting up a large driver into multiple patches. It just
means you have to download and apply all of them to get the global picture
needed for a proper review again. If a driver is too large for lkml a
pointer to a large patch is much much better for a proper review.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/