Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c

From: Geert Uytterhoeven
Date: Sun Jul 22 2007 - 06:20:28 EST


On Sat, 21 Jul 2007, Antonino A. Daplas wrote:
> On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote:
> > Fix following section mismatch warning:
> > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to .init.text:__alloc_bootmem (between 'vgacon_startup' and 'vgacon_scrolldelta')
> >
> > Browsing the code it seems that vgacon_scrollback_startup() is only
> > called during the init phase so the reference to the .init.text
> > section is OK.
> > Teach modpost not to warn using ___init_refok.
> >
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Acked-by: Antonino Daplas <adaplas@xxxxxxxxx>

I assume the check for `vga_init_done' in vgacon_startup() is sufficient to
prevent vgacon_scrollback_startup() from being called later due to
(un)bind_con_driver()?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/