Re: [PATCH] Use menuconfig objects - Fusion

[Robert P. J. Day]

On Sat, 21 Jul 2007, Jan Engelhardt wrote:

> -menu "Fusion MPT device support"
> +menuconfig FUSION
> +	bool "Fusion MPT device support"
>  	depends on PCI
> +	---help---
> +	Say Y here to get to see options for Fusion Message
> +	Passing Technology (MPT) drivers.
> +	This option alone does not add any kernel code.
> +
> +	If you say N, all options in this submenu will be skipped and disabled.
>
...
> +if FUSION
>
>  config FUSION_SPI
...
> +endif # FUSION


  i just *know* i'm going to regret asking this, but is there a
compelling reason why the internal contents of a "menuconfig FUBAR"
needs to still be surrounded by a "if FUBAR" condition?  wouldn't it
be philosophically cleaner if the internals of a menuconfig structure
*automatically* depended on selection of the menuconfig and the "if"
part was implicit?

  and having said that, i realize that there are menuconfig examples
for which the above is not strictly true, but i can't remember where
i've seen them.  all i remember about them is that they we're a bit
confusing.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/