Re: mm/Kconfig MEMORY_HOTPLUG typo ?

From: Paul Mundt
Date: Fri Jul 20 2007 - 08:37:29 EST


On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote:
> I'm a bit confused about the following from mm/Kconfig:
>
> ..
>
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> depends on SPARSEMEM || X86_64_ACPI_NUMA
> depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
> depends on (IA64 || X86 || PPC64 || SUPERH)
>
MEMORY_HOTPLUG is only supported if !SOFTWARE_SUSPEND

> comment "Memory hotplug is currently incompatible with Software Suspend"
> depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
>
>
> ...
>
> That should be !SOFTWARE_SUSPEND no ?
>
However, we only give the comment that warns about the incompatability
when SOFTWARE_SUSPEND is enabled, otherwise people won't see the option
due to the unmet dependency.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/