Re: i386: pata_cs5520 does not work

From: TAKADA Yoshihito
Date: Thu Jul 19 2007 - 20:49:23 EST


Hi.
That's good. It seems to works fine.

On Thu, 19 Jul 2007 16:18:21 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> O> > rc = devm_request_irq(&pdev->dev, irq[ap->port_no],
> > > ata_interrupt, 0, DRV_NAME, host);
> >
> > devm_request_irq() is called twice from loop.
> > In 1st time, ap->port_no is 0. devm_request_irq() is success.
> > 2nd time, ap->port_no is 0 too. devm_request_irq() failed.
>
> Looks like whoever updated it to the new probe mechanism didn't quite get
> it right
>
> Change it to use
>
> struct ata_port *ap = host->ports[i];
>
> not ports[0]
>
> Alan

--
TAKADA <takada@xxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/