Re: [PATCH] [15/58] i386: Rewrite sched_clock

[Daniel Walker]

On Thu, 2007-07-19 at 20:00 +0200, Andi Kleen wrote:
> On Thursday 19 July 2007 19:43:49 Daniel Walker wrote:
> > On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote:
> > > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote:
> > > 
> > > > >From my perspective a downside to sched_clock is that the math is
> > > > duplicated per architecture .. I think it would be a win to use the
> > > > generic functions if it's possible..
> > > 
> > > They can't be used because they're not cpu local. The whole basic 
> > > concept behind the new sched_clock is to be cpu local. 
> > 
> > Your not following me .. 
> 
> Because you don't make much sense. You're really asking me to factor
> an single multiplication and a shift (two CPU instructions!) out to share?

Yes, but I also said that was only part of the duplication. Your already
doing a re-write, there is no reason not to add this..

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/