[PATCH] Conexant 2388x: check for kthread_run

From: Cyrill Gorcunov
Date: Wed Jul 18 2007 - 14:56:44 EST


This patch adds checking of kthread_run return code.

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
---
Probably we could just ignore a such situation (we do
check for core->kthread value before trying to stop the
thread) but we have to leave a footmark in kernel
messages anyway I guess. Comments?

drivers/media/video/cx88/cx88-video.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 98fa354..2e05450 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -1881,8 +1881,15 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
mutex_unlock(&core->lock);

/* start tvaudio thread */
- if (core->tuner_type != TUNER_ABSENT)
+ if (core->tuner_type != TUNER_ABSENT) {
core->kthread = kthread_run(cx88_audio_thread, core, "cx88 tvaudio");
+ if (IS_ERR(core->kthread)) {
+ err = PTR_ERR(core->kthread);
+ printk(KERN_ERR "Failed to create cx88 audio thread, err=%d\n",
+ err);
+ goto fail_unreg;
+ }
+ }
return 0;

fail_unreg:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/