Re: [PATCH] Add nid sanity on alloc_pages_node

[Andrew Morton]

On Tue, 17 Jul 2007 20:49:25 +0100 (BST) Hugh Dickins <hugh@xxxxxxxxxxx> wrote:

> --- 2.6.22-git9/mm/hugetlb.c	2007-07-17 20:29:33.000000000 +0100
> +++ linux/mm/hugetlb.c	2007-07-17 20:32:51.000000000 +0100
> @@ -107,15 +107,12 @@ static int alloc_fresh_huge_page(void)
>  {
>  	static int prev_nid;
>  	struct page *page;
> -	static DEFINE_SPINLOCK(nid_lock);
>  	int nid;
>  
> -	spin_lock(&nid_lock);
>  	nid = next_node(prev_nid, node_online_map);
>  	if (nid == MAX_NUMNODES)
>  		nid = first_node(node_online_map);
>  	prev_nid = nid;
> -	spin_unlock(&nid_lock);

Given that we've now gone and added deliberate-but-we-hope-benign 
races into this code, an elaborate comment which explains and justifies
it all is pretty much obligatory, IMO.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/