Re: [PATCH] Kprobes - Declare kprobe_mutex static

From: Ananth N Mavinakayanahalli
Date: Tue Jul 17 2007 - 01:37:35 EST


On Sat, Jul 14, 2007 at 03:52:41PM -0400, Mathieu Desnoyers wrote:
> Kprobes - Declare kprobe_mutex static
>
> Since it will not be used by other kernel objects, it makes sense to declare it
> static.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>

Acked-by: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>

Thanks Mathieu

> CC: hch@xxxxxxxxxxxxx
> CC: prasanna@xxxxxxxxxx
> CC: ananth@xxxxxxxxxx
> CC: anil.s.keshavamurthy@xxxxxxxxx
> CC: davem@xxxxxxxxxxxxx
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-lttng/kernel/kprobes.c
> ===================================================================
> --- linux-2.6-lttng.orig/kernel/kprobes.c 2007-07-14 15:49:17.000000000 -0400
> +++ linux-2.6-lttng/kernel/kprobes.c 2007-07-14 15:49:27.000000000 -0400
> @@ -69,7 +69,7 @@ static atomic_t kprobe_count;
> /* NOTE: change this value only with kprobe_mutex held */
> static bool kprobe_enabled;
>
> -DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
> +static DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
> DEFINE_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
> static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
>
> --
> Mathieu Desnoyers
> Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/