Re: [PATCH] utime(s): Honour CAP_FOWNER when times==NULL

[Satyam Sharma]

On Tue, 17 Jul 2007, Al Viro wrote:
> On Tue, Jul 17, 2007 at 03:24:14AM +0530, Satyam Sharma wrote:
> > On Tue, 17 Jul 2007, Satyam Sharma wrote:
> > > [...]
> > > Anwyay, so I'm thinking of adding:
> > > 
> > > struct inode;
> > > 
> > > int is_not_owner(struct inode *)
> > 
> >   ^static inline                 ^inode
> > 
> > of course.
>  
> > > {
> > > 	return ((current->fsuid != inode->i_uid) && !capable(CAP_FOWNER));
> > > }
> 
> This is pointless.  If you do not have definition of struct inode
> already available, you'll get breakage on access to ->i_uid.

Yes, I realized that later :-) That was just a (dumb) sketch typed
into the mailer ... I'll send out the conversion patch after compiling
+ booting, of course.

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/