Re: [patch 1/5] avoid tlb gather restarts.

From: Andrew Morton
Date: Mon Jul 16 2007 - 02:21:08 EST


On Tue, 03 Jul 2007 13:18:23 +0200 Martin Schwidefsky <schwidefsky@xxxxxxxxxx> wrote:

> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> If need_resched() is false in the inner loop of unmap_vmas it is
> unnecessary to do a full blown tlb_finish_mmu / tlb_gather_mmu for
> each ZAP_BLOCK_SIZE ptes. Do a tlb_flush_mmu() instead. That gives
> architectures with a non-generic tlb flush implementation room for
> optimization. The tlb_flush_mmu primitive is a available with the
> generic tlb flush code, the ia64_tlb_flush_mm needs to be renamed
> and a dummy function is added to arm and arm26.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> ---
>
> include/asm-arm/tlb.h | 5 +++++
> include/asm-arm26/tlb.h | 5 +++++
> include/asm-ia64/tlb.h | 6 +++---
> mm/memory.c | 16 ++++++----------
> 4 files changed, 19 insertions(+), 13 deletions(-)

sparc64 broke:

mm/memory.c: In function `unmap_vmas':
mm/memory.c:862: error: too many arguments to function `tlb_flush_mmu'

grep, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/