Re: [PATCH] remove PAGE_SIZE from headers_install

From: Mikael Pettersson
Date: Sat Jul 14 2007 - 17:41:13 EST


On Sat, 14 Jul 2007 14:12:57 -0700, H. Peter Anvin wrote:
> Olaf Hering wrote:
> > Declare PAGE_SIZE as getpagesize() for userspace.
> > PAGE_SIZE is used in resource.h and shm.h
>
> I would think it would be better to not define it at all. Several
> architectures already don't have PAGE_SIZE visible to userspace in any way.

Furthermore, the kernel should /not/ export a would-be kernel
interface by defining it in terms of a non-kernel interface.
getpagesize() belongs to libc, and might not exist at all or
have that form.

Linux is not Solaris. There can be many different libcs in a system.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/