Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

[Pekka Enberg]

On 7/13/07, Kalpak Shah <kalpak@xxxxxxxxxxxxx> wrote:
> > EXT4_DIR_LINK_MAX() is buggy: it evaluates its arg twice.
>
> #define EXT4_DIR_LINK_MAX(dir) (!is_dx(dir) && (dir)->i_nlink >= EXT4_LINK_MAX)

[snip]

> Sorry, I didn't understand what is the problem with this macro?

The expression represented by 'dir' is evaluated twice (think dir++
here). It's safer to make it a static inline function.

                                      Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/