Re: [PATCH 1/1] x86-64: introduce struct pci_sysdata to facilitatesharing of ->sysdata

From: Arjan van de Ven
Date: Wed Jul 11 2007 - 21:18:21 EST


On Wed, 2007-07-11 at 16:45 +0300, Muli Ben-Yehuda wrote:
> Andi, please consider applying for 2.6.23. Applies on top of the
> Calgary update I just sent out ("Calgary: more updates for 2.6.23").
>
> This patch introduces struct pci_sysdata to x86 and x86-64, and
> converts the existing two users (NUMA, Calgary) to use it.
>
> This lays the groundwork for having other users of sysdata, such as
> the PCI domains work.
>
> The Calgary bits are tested, the NUMA bits just look ok.


I very much start to dislike the untyped "sysdata"... I much rather have
separate fields for the different uses (like a IOMMU field) that aren't
going to share ever. Possibly even typed, but for IOMMU that may be
tricky....



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/