Re: [PATCH] Optimize struct task_delay_info

From: Andi Kleen
Date: Wed Jul 11 2007 - 07:32:07 EST


"Zhang, Yanmin" <yanmin_zhang@xxxxxxxxxxxxxxx> writes:
> replace them;
> 2) Delete lock. The change to the protected data has no nested cases.
> In addition, the result is for performance data collection, so itʼs
> unnecessary to add such lock.

Not sure that's a good idea. People expect their performance counts
to be accurate too. You could possibly use atomics though, but
when there are multiple counters updated the spinlock will be likely
faster.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/