Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

[Cédric Augonnet]

2007/7/10, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:

Hi all,

> > +     size = sizeof(struct transaction_stats_s);
> > +     s->stats = kmalloc(size, GFP_KERNEL);
> > +     if (s == NULL) {
> > +             kfree(s);
> > +             return -EIO;
>
> ENOMEM

I'm sorry if i missed some point, but i just don't see the use of such
a kfree here, not sure Andrew meant you should only return ENOMEM
instead, but why issuing those kfree(NULL), instead of just a if (!s)
return ENOMEM ?

Regards,
Cédric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/