Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order

From: Ingo Molnar
Date: Sun Jul 08 2007 - 08:22:15 EST



* Avi Kivity <avi@xxxxxxxxxxxx> wrote:

> From: Shaohua Li <shaohua.li@xxxxxxxxx>
>
> Need to flush the tlb after updating a pte, not before.

> rmap_remove(vcpu, spte);
> - kvm_flush_remote_tlbs(vcpu->kvm);
> set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK);
> + kvm_flush_remote_tlbs(vcpu->kvm);

hm, isnt this a must-have fix for v2.6.22 (and .21) as well?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/