Re: [PATCH] ioremap: fix iounmap numpages

From: Jeremy Fitzhardinge
Date: Fri Jun 29 2007 - 08:37:32 EST


Dave Young wrote:
Hi,
The second parameter of change_page_attr in iounmap is wrong, it should be (p->size - 1) >> PAGE_SHIFT

Why's that? Isn't p->size always going to be a pagesize multiple; in which case, why would you want to change_page_attr on n-1 pages?

Are you seeing a problem that this patch fixes?

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/