Re: pci.h stubs (was: EDD build error)

[Matthew Wilcox]

On Wed, Jun 27, 2007 at 03:32:58PM +0100, Alan Cox wrote:
> On Wed, 27 Jun 2007 08:03:05 -0600
> Matthew Wilcox <matthew@xxxxxx> wrote:
> 
> > On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote:
> > > On Wed, 27 Jun 2007 05:30:48 -0600
> > > Matthew Wilcox <matthew@xxxxxx> wrote:
> > > > pci_get_bus_and_slot() shouldn't be used because it fails to work on
> > > > systems with multiple domains.  pci_get_slot() avoids this problem (and
> > > > is much faster too).
> > > 
> > > But requires you have a bus pointer to hand which is often not the
> > > case. Do we need pci_get_domain_bus_and_slot() ?
> > 
> > We have pci_find_bus(domain, busnr) which will get you the bus pointer.
> 
> So the answer is "yes" we should then, and move from pci_get_bus_and_slot
> to pci_get_bus_domain_and_slot() [or just add an argument]. The point of
> the functions is to be easy to use, so it should be handled internally.

My point was that code which doesn't currently keep the bus pointer to
hand should keep the bus pointer to hand instead of the bus number.
That's easier to use, particularly if you want to actually do any pci
config accesses.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/