Re: [PATCH] trim memory not covered by WB MTRRs

[Mauro Giachero]

On 6/27/07, Pim Zandbergen <P.Zandbergen@xxxxxxxxxxxxx> wrote:
> Now:
> Jesse released a new patch and I tried if for fun on 2.6.22-rc6
> It looks like the patch is releasing memory rather than trimming it:
>
> [...]
> Jun 27 12:22:56 corneille kernel: **** MTRRs don't cover all of memory,
> trimmed -65536 pages
> [...]

> From Jesse's patch:
> +       unsigned long i, base, size, highest_addr = 0, def, dummy;
> [...]
> +               printk(KERN_WARNING "**** MTRRs don't cover all of "
> +                      "memory, trimmed %ld pages\n", end_pfn -
> +                      (highest_addr >> PAGE_SHIFT));

Since both end_pfn (from arch/x86_64/kernel/e820.c) and highest_addr
are unsigned long, maybe the problem is just that %ld in the kprintf
format string? Shouldn't that be %lu?

Mauro
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/