Re: [-mm patch] remove nobh_{prepare,commit}_write()

From: Randy Dunlap
Date: Tue Jun 26 2007 - 17:35:06 EST


On Tue, 26 Jun 2007 14:23:20 -0700 Andrew Morton wrote:

> On Tue, 26 Jun 2007 15:48:58 -0500
> Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxxxx> wrote:
>
> > On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote:
> > > On Fri, 15 Jun 2007 00:15:55 +0200
> > > Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > >
> > > > nobh_{prepare,commit}_write() are no longer used.
> > >
> > > wth? What happened to ext2 and ext3 nobh mode? They seem to
> > > have magically and unchangeloggedly disappeared?
> >
> > They were removed with Nick's new aops patches.
> ^secretly
> >
>
> That much I worked out for myself. It's kinda staggering that a fairly
> major feature in two fairly major filesystems got removed without even a
> mention in the changelog. I don't recall having seen it discussed in email
> but I obviously missed that bit.
>
> Look, I'm one micron from just dropping the whole lot. These changes
> simply have not received the amount of energy, effort, care, attention and
> testing which a change of this magnitude requires.

so be sure to discuss that (not the patches themselves so much,
but the process(es)) at the kernel summit etc....


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/