Re: [PATCH 1/2] [RESEND] PCI: read revision ID by default

From: Alan Cox
Date: Mon Jun 25 2007 - 04:57:05 EST


On Sun, 24 Jun 2007 20:19:18 -0700
Auke Kok <auke-jan.h.kok@xxxxxxxxx> wrote:

> Currently there are 97 occurrences where drivers need the pci
> revision ID. We can do this once for all devices. Even the pci
> subsystem needs the revision several times for quirks. The extra
> u8 member pads out nicely in the pci_dev struct.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@xxxxxxxxx>

Seems worth caching yes. Care needed changing the other uses however
that the revision isn't changeable on the hardware in some magic fashion.

Acked-by: Alan Cox <alan@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/