Re: [PATCH] update checkpatch.pl to version 0.06

From: Dave Hansen
Date: Fri Jun 22 2007 - 14:02:23 EST


On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> If it is "kinda like a mini function" why not make it "actually a mini
> function" and call it?

Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.

I think it's worse style to be mixing label indentation in a file as it
is to create new "correct" indentation labels. That's why I suggested
using context in the file to determine it rather than absolute rules.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/