Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

From: Andrew Morton
Date: Fri Jun 22 2007 - 09:49:04 EST


> On Fri, 22 Jun 2007 15:26:22 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > I do think that would be a better approach. Apart from the
> > cleanliness issue, the driver-by-driver conversion would make it much
> > easier to hunt down any regresions or various funnineses.
>
> there are 120 tasklet_init()s in the tree and 224 tasklet_schedule()s.

couple of hours?

> Pushing it into thread context should work just fine (Steve's patchset
> certainly works on my testbox), as even today we can execute softirqs
> (and hence tasklets) in ksoftirqd. In fact, -rt has been executing
> tasklets in task context for over 2.5 years meanwhile. Do we really want
> to upset the whole API? Realistically it just wont ever be removed, like
> the BKL.

We can remove it. It might need to remain deprecated for a year, but we
shouldn't plan on leaving the old interface hanging around for ever.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/