Re: [patch] spinlock debug: make looping nicer

From: Ingo Molnar
Date: Thu Jun 21 2007 - 17:16:20 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 21 Jun 2007, Ingo Molnar wrote:
> >
> > btw., back then we also tried a spin_is_locked() based inner loop
> > but it didnt help the ->tree_lock lockups either. In any case i very
> > much agree that the 'nicer' looping should be added again - the
> > patch below does that. (build and boot tested)
>
> Ok, I'm definitely not going to apply it right now, though.

yeah, very much so. Lots of distros ship with spinlock debugging enabled
(at least in their betas), we dont want to break that accidentally.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/