Re: [RFC] clocksouce implementation for powerpc

From: Sergei Shtylyov
Date: Wed Jun 20 2007 - 14:10:31 EST


Hello.

Thomas Gleixner wrote:

+void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
+{
+ timer_recalc_offset(tb_last_jiffy);
+ timer_check_rtc();
+}

Hmm .. This doesn't look like it's taking into account that the time has
changed ..

Why? By the time it gets called (form the timer softirq context)


It is called from interrupt context at least in mainline. Only the -rt
patch moves this to the softirq.

Anyway, by the time it gets called, tb_last_jiffy gets updated.

tglx

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/