Re: [PATCH -mm] add a kmem_cache for nsproxy objects

From: Christoph Hellwig
Date: Tue Jun 19 2007 - 15:04:22 EST


On Tue, Jun 19, 2007 at 11:35:01AM -0700, Andrew Morton wrote:
> On Mon, 18 Jun 2007 22:53:13 +0200
> Cedric Le Goater <clg@xxxxxxxxxx> wrote:
>
> > +static int __init nsproxy_cache_init(void)
> > +{
> > + nsproxy_cachep = kmem_cache_create("nsproxy", sizeof(struct nsproxy),
> > + 0, SLAB_PANIC, NULL, NULL);
> > + return 0;
> > +}
> > +
>
> Christoph added this cheesy KMEM_CACHE macro. But I don't immediately recall
> the rationale so I'm a bit reluctant to ask people to use-the-cheesy-macro.
>
> Perhaps he can remind us why it is there?

Hmm, I must have missed the macro going in. Frankly speaking I plain hate
it. It's a rather useless obsfucation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/