Re: [PATCH 1/7] KAMEZAWA Hiroyuki hot-remove patches

From: Christoph Lameter
Date: Mon Jun 18 2007 - 12:56:29 EST


On Mon, 18 Jun 2007, Mel Gorman wrote:

> @@ -632,18 +632,27 @@ static int unmap_and_move(new_page_t get
> goto unlock;
> wait_on_page_writeback(page);
> }
> -
> + /* anon_vma should not be freed while migration. */
> + if (PageAnon(page)) {
> + rcu_read_lock();
> + rcu_locked = 1;
> + }

We agreed on doing rcu_read_lock removing the status variable
and checking for PageAnon(). Doing so deuglifies the
function.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/