Re: [PATCH 1/6] make pci_ids lowercase hexa

From: Jiri Slaby
Date: Mon Jun 18 2007 - 04:39:19 EST


Greg KH napsal(a):
> On Sun, Jun 17, 2007 at 09:08:31AM +0200, Jiri Slaby wrote:
>> Greg KH napsal(a):
>>> Why? What good is this going to do in the long run?
>> It's just cleanup to get rid of things like this:
>> #define PCI_DEVICE_ID_PROMISE_20246 0x4d33
>> #define PCI_DEVICE_ID_PROMISE_20262 0x4d38
>> -#define PCI_DEVICE_ID_PROMISE_20263 0x0D38
>> +#define PCI_DEVICE_ID_PROMISE_20263 0x0d38
>> #define PCI_DEVICE_ID_PROMISE_20268 0x4d68
>
> Get rid of what? What's wrong with upper case hex numbers? This seems
> like a pretty gratitous change to me.

Ok.

> Care to resend your other fixes to me, if you still think they are
> needed?

Sure.

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/