Re: [PATCH] Introduce compat_u64 and compat_s64 types
From: David Woodhouse
Date: Fri Jun 15 2007 - 08:38:47 EST
On Fri, 2007-06-15 at 06:11 -0600, Matthew Wilcox wrote:
> You're relying on compat_[us]64 being only used in structures which are
> already packed.
In which case the whole exercise is pointless, on account of the
structure being already packed. It was _already_ laid out the same on
32-bit and 64-bit builds.
> If someone uses them in a non-packed struct, they won't
> decrease the alignment. I think it would be more effective to specify
> it as:
> __attribute__((aligned(4), packed))
Good point. Yes, it looks like we need the additional 'packed' in order
for the aligned(4) to be anything other than a no-op.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/