Re: [PATCH -mm 4/7] PM: Remove suspend and resume support from struct device_type

From: Rafael J. Wysocki
Date: Thu Jun 14 2007 - 19:23:58 EST


On Friday, 15 June 2007 01:14, Greg KH wrote:
> On Fri, Jun 15, 2007 at 12:32:19AM +0200, Rafael J. Wysocki wrote:
> > On Thursday, 14 June 2007 19:46, Greg KH wrote:
> > > On Thu, Jun 14, 2007 at 08:59:20AM -0400, Dmitry Torokhov wrote:
> > > > On 6/14/07, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > > > > On Thursday, 14 June 2007 06:10, Dmitry Torokhov wrote:
> > > > > > On Wednesday 13 June 2007 18:20, Kay Sievers wrote:
> > > > > > > Dmitry, you added this recently, is this used in any code you plan to
> > > > > > > merge soon?
> > > > > > >
> > > > > >
> > > > > > Yes, I will need it to implement input device resume (mainly to restore
> > > > > LED
> > > > > > state and repeat rate for keyboards).
> > > > >
> > > > > Would that be a big problem to reintroduce it along with the user?
> > > > >
> > > >
> > > > Yes because that part is in Greg's domain so I am trying to set
> > > > infrastructure up before I can commit my patches into my tree so that
> > > > Andrew can safely pull from me into -mm. Greg normally adds such stuff
> > > > during merge window so that means if we remove it now we'd need ~2
> > > > releases to get it and the user back in.
> > >
> > > Yes, don't worry, I'm not going to remove this as I know you rely on it.
> >
> > Hm, in that case I'd have to rework the patches 5-7. Perhaps I should resend
> > the entire series once again, without the $subject patch?
>
> Ok, yeah, can you rework those three patches and resend them?

Sure, I will.

> I took patches 1-3 already.

Thanks!

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/