Re: [PATCH] nbd.c:sock_xmit: cleanup signal related code

From: Paul Clements
Date: Thu Jun 14 2007 - 15:36:50 EST


Oleg Nesterov wrote:
sock_xmit() re-implements sigprocmask() and dequeue_signal_lock().

Yeah, that code was written before those existed. Thanks for the clean up.

Note: I can't understand this dequeue_signal(), it can dequeue SIGKILL
for the user-space task doing nbd_ioctl() ?

So we can interrupt an nbd transmission without waiting for a TCP timeout (when we know the network is down).

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Patch looks good to me.

--
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/