Re: [patch] sched: fix SysRq-N (normalize RT tasks)

From: Måns Rullgård
Date: Thu Jun 14 2007 - 15:10:21 EST

Ingo Molnar <mingo@xxxxxxx> writes:

> From: Ingo Molnar <mingo@xxxxxxx>
> Subject: [patch] sched: fix SysRq-N (normalize RT tasks)
> Gene Heskett reported the following problem while testing CFS: SysRq-N
> is not always effective in normalizing tasks back to SCHED_OTHER.
> the reason for that turns out to be the following bug:
> normalize_rt_tasks() uses for_each_process() to iterate through all
> tasks in the system. The problem is, this method does not iterate
> through all tasks, it iterates through all thread groups. The proper
> mechanism to enumerate all tasks is to use a do_each_thread() +
> while_each_thread() loop.

Was this always a bug or did the meaning of for_each_process() change
since this code was added?

Måns Rullgård

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at