Re: [patch 0/3] AHCI Link Power Management

[Tejun Heo]

Jens Axboe wrote:
>> 1. It didn't have proper interface with userland.  This was mainly
>> because of missing ATA sysfs nodes.  I'm not sure whether adding this to
>> scsi node is a good idea.
>>
>> 2. It was focused on SATA link PS and couldn't cover the Lenovo case.
>>
>> I think we need something at the block layer.
> 
> I think the hardware method is preferable, actually. Doing this in the
> block layer would mean keeping track of idle time, and that quickly
> turns into a lot of timer management. Not exactly free, in terms of CPU
> usage.

Yeah, software implementation certainly has complexity overhead.

> I've yet to do some power measurements with this ahci patch, I just
> noticed that with min_power performance drops from ~55mb/sec to
> ~15mb/sec sequential on my drive. That's pretty drastic :-)

That's another thing I don't like about ALPE/ASP.  According to the
spec, there is no idle timer whatsoever.  The controller is supposed to
drive the link into PS mode whenever FIS is not in flight, so the link
goes in and out of PS state repeatedly when commands are issued
back-to-back.  Getting out of PS state takes a bit of time and slows
down things.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/