[patch] sched: fix SysRq-N (normalize RT tasks)

From: Ingo Molnar
Date: Thu Jun 14 2007 - 05:48:51 EST

From: Ingo Molnar <mingo@xxxxxxx>
Subject: [patch] sched: fix SysRq-N (normalize RT tasks)

Gene Heskett reported the following problem while testing CFS: SysRq-N
is not always effective in normalizing tasks back to SCHED_OTHER.

the reason for that turns out to be the following bug:
normalize_rt_tasks() uses for_each_process() to iterate through all
tasks in the system. The problem is, this method does not iterate
through all tasks, it iterates through all thread groups. The proper
mechanism to enumerate all tasks is to use a do_each_thread() +
while_each_thread() loop.

obvious bugfix for v2.6.22 inclusion. -stable candidate as well.

Reported-by: Gene Heskett <gene.heskett@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
kernel/sched.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Index: linux/kernel/sched.c
--- linux/kernel/sched.c
+++ linux/kernel/sched.c
@@ -7071,12 +7071,13 @@ EXPORT_SYMBOL(__might_sleep);
void normalize_rt_tasks(void)
struct prio_array *array;
- struct task_struct *p;
+ struct task_struct *g, *p;
unsigned long flags;
struct rq *rq;

- for_each_process(p) {
+ do_each_thread(g, p) {
if (!rt_task(p))

@@ -7094,7 +7095,8 @@ void normalize_rt_tasks(void)

spin_unlock_irqrestore(&p->pi_lock, flags);
- }
+ } while_each_thread(g, p);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/