Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines
From: Doug Thompson
Date: Wed Jun 13 2007 - 01:11:21 EST
--- Dave Jones <davej@xxxxxxxxxx> wrote:
> On Mon, Jun 11, 2007 at 04:49:47PM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Jun 11, 2007 at 04:30:11PM -0700, Doug Thompson wrote:
> > > I am working with the k8 driver and its dealing with a race with the mcelog device as both
> > > the K8 NB. The K8 driver does use these regs and it currently has #ifndef s in it for both
> > > them.
> > >
> > > I guess I could have submitted the patch when the K8 driver was submitted.
> > That would be preferable, thanks.
> Even better (IMO), if they're not used by any other driver (which seems
> to be the case), keep the defines local to the driver.
There are 4 K8 Memory Controller registers, 2 of which are already in pci_ids.h (and are used by
others) and 2 more that I need. I define the 2 I need now in the file, but was worried when
someone else might add them to the pci_ids.h file. Just figured that it would be better to keep
all 4 together.
So is the model of such placement to locate the #define near to the sole consumer of that item?
And if used by others, to move it to the pci_ids.h file?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/